Fix bug in find-changes workflow & rename workflows for greater clarity#874
Merged
Fix bug in find-changes workflow & rename workflows for greater clarity#874
Conversation
github-actions
Bot
added
size: S
The values from workflow calls turn out _always_ to be strings,
even when you try to make sure to produce Booleans. This means
tests of values output by workflows called by other workflows
have to be of the form `${{variable == 'true'}}` rather than
(e.g.) `${{variable}}` or even `${{variable == true}}`. This is
poorly documented in GitHub's documentation, IMHO.
Along with fixing the conditionals, this PR renames the reusable
workflow files to start with leading underscore characters. That
seems to be more conventional in other GitHub repos.
mhucka
force-pushed
the
mh-fix-find-changes-workflow
branch
from
75b940f to
27a5680
Compare
mhucka
force-pushed
the
mh-fix-find-changes-workflow
branch
from
de32cc4 to
0fa053d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values from called workflows turn out to always be strings, even when you try to make sure to produce Booleans. This means tests of values output by workflows called by other workflows have to be of the form
${{variable == 'true'}}rather than (e.g.)${{variable}}or even${{variable == true}}. This is poorly documented in GitHub's documentation, IMHO, and incredibly error-prone.Along with fixing the conditionals, this PR renames the reusable workflow files to start with leading underscore characters. That seems to be more conventional in other GitHub repos.